Skip to content

fix: handle bitmap index overflow by implementing a multibatch solution #3515#3784

Closed
HaochengLIU wants to merge 3 commits intolance-format:mainfrom
HaochengLIU:3515-address-overflow-byte-array-offset-with-multiple-batches
Closed

fix: handle bitmap index overflow by implementing a multibatch solution #3515#3784
HaochengLIU wants to merge 3 commits intolance-format:mainfrom
HaochengLIU:3515-address-overflow-byte-array-offset-with-multiple-batches

Conversation

@HaochengLIU
Copy link
Copy Markdown
Member

@HaochengLIU HaochengLIU commented May 7, 2025

Fix bitmap index overflow by implementing a multibatch solution #3515

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2025

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@HaochengLIU HaochengLIU force-pushed the 3515-address-overflow-byte-array-offset-with-multiple-batches branch 2 times, most recently from 167e460 to b6f43e3 Compare May 7, 2025 14:00
@github-actions github-actions bot added the python label May 7, 2025
@HaochengLIU HaochengLIU changed the title WIP Fix bitmap index overflow by implementing a multibatch solution #3515 fix: handle bitmap index overflow by implementing a multibatch solution #3515 May 7, 2025
@github-actions github-actions bot added the bug Something isn't working label May 7, 2025
@HaochengLIU HaochengLIU force-pushed the 3515-address-overflow-byte-array-offset-with-multiple-batches branch 3 times, most recently from bdffa2b to f647e62 Compare May 7, 2025 14:51
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2025

Codecov Report

Attention: Patch coverage is 79.43925% with 22 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (985a488) to head (96925d7).

Files with missing lines Patch % Lines
rust/lance-index/src/scalar/bitmap.rs 79.43% 17 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3784      +/-   ##
==========================================
- Coverage   78.58%   78.56%   -0.02%     
==========================================
  Files         273      273              
  Lines      101936   102024      +88     
  Branches   101936   102024      +88     
==========================================
+ Hits        80102    80154      +52     
- Misses      18667    18703      +36     
  Partials     3167     3167              
Flag Coverage Δ
unittests 78.56% <79.43%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HaochengLIU HaochengLIU force-pushed the 3515-address-overflow-byte-array-offset-with-multiple-batches branch from f647e62 to 96925d7 Compare May 7, 2025 15:37
@HaochengLIU HaochengLIU changed the title fix: handle bitmap index overflow by implementing a multibatch solution #3515 [WIP] fix: handle bitmap index overflow by implementing a multibatch solution #3515 May 7, 2025
@HaochengLIU HaochengLIU force-pushed the 3515-address-overflow-byte-array-offset-with-multiple-batches branch from 3468649 to 0a0f406 Compare May 8, 2025 02:11
@HaochengLIU HaochengLIU force-pushed the 3515-address-overflow-byte-array-offset-with-multiple-batches branch from 0a0f406 to 78e1943 Compare May 8, 2025 02:12
@HaochengLIU HaochengLIU marked this pull request as draft May 8, 2025 03:04
@HaochengLIU HaochengLIU changed the title [WIP] fix: handle bitmap index overflow by implementing a multibatch solution #3515 fix: handle bitmap index overflow by implementing a multibatch solution #3515 May 8, 2025
@HaochengLIU HaochengLIU closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants