feat: split large reads into smaller parallel reads#3801
Merged
westonpace merged 2 commits intolance-format:mainfrom May 13, 2025
Merged
feat: split large reads into smaller parallel reads#3801westonpace merged 2 commits intolance-format:mainfrom
westonpace merged 2 commits intolance-format:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3801 +/- ##
========================================
Coverage 78.60% 78.61%
========================================
Files 274 274
Lines 102487 102601 +114
Branches 102487 102601 +114
========================================
+ Hits 80564 80656 +92
- Misses 18743 18759 +16
- Partials 3180 3186 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ce7a38b to
00f3dde
Compare
LuQQiu
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can often end up with large pages. This is easier in 2.1 than it is in 2.0 but it can happen in 2.0 as well. When this happens we make one large request into object storage. However, these large requests are problematic. Partly because we get less performance (less parallelism) and partly because they are prone to failure, especially timeout, when the object store is under stress. As a result, it is better to split requests into smaller requests.