Skip to content

fix: update size of data file in data replacement operation#3839

Merged
westonpace merged 1 commit intolance-format:mainfrom
westonpace:fix/update-size-in-data-replacement
May 17, 2025
Merged

fix: update size of data file in data replacement operation#3839
westonpace merged 1 commit intolance-format:mainfrom
westonpace:fix/update-size-in-data-replacement

Conversation

@westonpace
Copy link
Copy Markdown
Member

In the data replacement operation we find an existing file and change the path. We also need to change the size of the file as well.

@github-actions
Copy link
Copy Markdown
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

Copy link
Copy Markdown
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.64%. Comparing base (b42ca9b) to head (3d1ab26).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3839      +/-   ##
==========================================
- Coverage   78.64%   78.64%   -0.01%     
==========================================
  Files         274      274              
  Lines      104612   104613       +1     
  Branches   104612   104613       +1     
==========================================
- Hits        82269    82268       -1     
  Misses      19092    19092              
- Partials     3251     3253       +2     
Flag Coverage Δ
unittests 78.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@westonpace westonpace changed the title fix; update size of data file in data replacement operation fix: update size of data file in data replacement operation May 17, 2025
@github-actions github-actions bot added the bug Something isn't working label May 17, 2025
@westonpace westonpace merged commit 510438a into lance-format:main May 17, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants