ref(js): use fs.rmSync
#1167
Merged
ref(js): use fs.rmSync
#1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of `rm` for better error handling
Contributor
|
Mintlify preview ID generated: preview-mdrxyf-1761678411-491188a |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the safety and cross-platform compatibility of the remote repository cleanup operation by replacing a shell command with native Node.js file system API.
Key Changes:
- Replaced the
exec(["rm -rf", target])shell command with Node.js nativefs.rmSync()with appropriate options - Added an existence check before attempting to remove the directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
rmfor better error handlingre: recent build fail as a result of a race condition(?)