-
Notifications
You must be signed in to change notification settings - Fork 998
1.1 release notes #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.1 release notes #1555
Conversation
lnhsingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do a more thorough review once we have more content in if needed
| "group": "Releases", | ||
| "pages": [ | ||
| "oss/python/releases/langchain-v1" | ||
| "oss/python/releases/langchain-v1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's order this newest to oldest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, can you remove the /releases/langchain-v1 from the langchain tab?
i think the release notes should live in the Reference tab and we can keep the migration guide on the main tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's order this newest to oldest
This will break the drilldown nav. It needs either needs to be old -> new (within the current setup) or we need to un-nest the releases dropdown in the left sidebar.
https://www.mintlify.com/docs/organize/navigation#enable-auto-navigation-for-groups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to refactor this area to not be in a sidebar nav folder, as drilldown to v1 always is not wanted
|
|
||
| ## See also | ||
|
|
||
| - [Versioning](/oss/python/versioning) - Understanding version numbers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe these should be combined w the "Additional resources" section?
ccurme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My own bias is it's overkill to have separate documents for every release.
I think there will be circumstances where we don't want to batch changes (e.g., we want to quickly make a semver-minor change to langchain or langchain-core to unblock something). Are we OK having a page that's a single line of text describing it?
I like OpenAI's changelog: https://platform.openai.com/docs/changelog
This is a single page with bullets hitting what's new at a high-level and linking out to more detailed docs.
I'm OK to ship this and compile into a a single page later if preferred.
|
closing in favor of the more simple #1581 |
No description provided.