Skip to content

Conversation

@barnuri
Copy link
Contributor

@barnuri barnuri commented Nov 17, 2025

This pull request adds support for passing custom vector index options throughout the vector search index creation and update workflows in the MongoDB integration. This enhancement allows users to specify additional parameters for vector index configuration, increasing flexibility and control over index behavior.

Enhancements to vector index configuration:

  • Added a new vector_index_options parameter to the _vector_search_index_definition, create_vector_search_index, and update_vector_search_index functions in index.py, enabling custom options to be merged into the index definition. [1] [2] [3] [4] [5]
  • Updated the MongoDBAtlasVectorSearch class in vectorstores.py to accept and forward the vector_index_options parameter during initialization and index creation, ensuring consistent propagation of custom options. [1] [2] [3] [4]Issue Key

@blink1073
Copy link
Collaborator

Hi @barnuri, thank you for the PR! We are in the process of centralizing this logic in pymongo_search_utils. See #208. Would you like to make a PR there instead?

@barnuri
Copy link
Contributor Author

barnuri commented Nov 19, 2025

Hi @barnuri, thank you for the PR! We are in the process of centralizing this logic in pymongo_search_utils. See #208. Would you like to make a PR there instead?

mongodb-labs/pymongo-search-utils#14

@barnuri
Copy link
Contributor Author

barnuri commented Nov 24, 2025

@blink1073
the pr mongodb-labs/pymongo-search-utils#14 merged
how we should continue ?
i see #208 didnt merge yet

@blink1073 blink1073 changed the title vector_index_options INTPYTHON-838 Allow additional arguments to vector_search_index_definition Nov 24, 2025
@blink1073
Copy link
Collaborator

Hi @barnuri, we hope to release pymongo-search-utils 0.1.0 and merge #208 today or tomorrow, then we can continue with this PR.

@blink1073
Copy link
Collaborator

This is unblocked, but has a merge conflict now

@barnuri
Copy link
Contributor Author

barnuri commented Nov 24, 2025

@blink1073 fixed

@blink1073
Copy link
Collaborator

Patch build: https://spruce.mongodb.com/version/6924bcac9651460007cc4972/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@barnuri
Copy link
Contributor Author

barnuri commented Nov 25, 2025

@blink1073 can you merge it ? so it will be in the next release you said ? 0.9

@blink1073 blink1073 merged commit c07c9b2 into langchain-ai:main Nov 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants