-
Notifications
You must be signed in to change notification settings - Fork 38
INTPYTHON-838 Allow additional arguments to vector_search_index_definition #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @barnuri, thank you for the PR! We are in the process of centralizing this logic in pymongo_search_utils. See #208. Would you like to make a PR there instead? |
|
|
@blink1073 |
|
This is unblocked, but has a merge conflict now |
|
@blink1073 fixed |
blink1073
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
|
@blink1073 can you merge it ? so it will be in the next release you said ? 0.9 |
This pull request adds support for passing custom vector index options throughout the vector search index creation and update workflows in the MongoDB integration. This enhancement allows users to specify additional parameters for vector index configuration, increasing flexibility and control over index behavior.
Enhancements to vector index configuration:
vector_index_optionsparameter to the_vector_search_index_definition,create_vector_search_index, andupdate_vector_search_indexfunctions inindex.py, enabling custom options to be merged into the index definition. [1] [2] [3] [4] [5]MongoDBAtlasVectorSearchclass invectorstores.pyto accept and forward thevector_index_optionsparameter during initialization and index creation, ensuring consistent propagation of custom options. [1] [2] [3] [4]Issue Key