Skip to content

Chore/removed unused e2e secrets #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025
Merged

Chore/removed unused e2e secrets #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1eb8f76
chore: added case for optional aws cache invalidation distribution id…
alexander-schefe Aug 11, 2025
d524d7b
chore: readded e2e retries
alexander-schefe Aug 11, 2025
3c71d74
fix: use environment secrets instead of if-case for distribution id
alexander-schefe Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/reusable-e2e-test-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ jobs:
env:
USER_ID: ${{ secrets.TEST_TRAINEE_ID }}
URL: ${{ secrets.FRONTEND_URL }}
BASICAUTHENTICATION_USERNAME: ${{ secrets.BASICAUTHENTICATION_USERNAME }}
BASICAUTHENTICATION_PASSWORD: ${{ secrets.BASICAUTHENTICATION_PASSWORD }}
ENVIRONMENT_NAME: staging
steps:
- uses: actions/checkout@v4
Expand All @@ -42,11 +40,6 @@ jobs:
npx playwright install
npx playwright test --output test-results --config playwright.config.ts

- if: failure()
run: |
cd packages/e2e
npx playwright show-trace test-results/tests-entry-entry-switch-language-chromium/trace.zip

- name: Upload Playwright test results
if: failure()
uses: actions/upload-artifact@v4
Expand Down
7 changes: 1 addition & 6 deletions packages/e2e/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
// playwright.config.ts
import { PlaywrightTestConfig, devices } from '@playwright/test'
const { BASICAUTHENTICATION_USERNAME, BASICAUTHENTICATION_PASSWORD } = process.env

const config: PlaywrightTestConfig = {
forbidOnly: !!process.env.CI,
retries: 0,
retries: process.env.CI ? 2 : 0,
outputDir: 'test-results',
use: {
trace: 'on',
Expand All @@ -14,10 +13,6 @@ const config: PlaywrightTestConfig = {
name: 'chromium',
use: {
...devices['Desktop Chrome'],
httpCredentials: {
username: BASICAUTHENTICATION_USERNAME ? BASICAUTHENTICATION_USERNAME : '',
password: BASICAUTHENTICATION_PASSWORD ? BASICAUTHENTICATION_PASSWORD : '',
},
},
},
// {
Expand Down
1 change: 0 additions & 1 deletion packages/e2e/tests/entry.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ URL ??= 'http://localhost:8080'
async function goto(page: Page, path: string = '') {
await page.goto(`${URL}${path}`)
const statusBar = page.locator('#status-bar')
await statusBar.waitFor({ timeout: 10000 })
await statusBar.hover()

const input = page.locator('#dev-login-user-id')
Expand Down