Skip to content

fix: update S3 bucket policy to deny HTTP traffic #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix: update S3 bucket policy to deny HTTP traffic #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cf089e
fix: update S3 bucket policy to deny HTTP traffic
timbru31 Nov 3, 2023
ad0f1ce
style: fix quotes
timbru31 Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 43 additions & 7 deletions serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,17 +445,53 @@ resources:
PolicyForCloudFrontPrivateContent:
Type: 'AWS::S3::BucketPolicy'
Properties:
Bucket:
Ref: FrontendBucket
Bucket: !Ref FrontendBucket
PolicyDocument:
Version: '2008-10-17'
Version: '2012-10-17'
Statement:
- Sid: AllowCloudFrontServicePrincipal
Effect: Allow
Principal:
Service: cloudfront.amazonaws.com
Action: s3:GetObject
Resource: arn:aws:s3:::${self:provider.environment.COMPANY_ABBREVIATION}-lara-frontend-${self:custom.stage}/*
AWS:Service: cloudfront.amazonaws.com
Action: 's3:GetObject'
Resource:
Fn::Sub: 'arn:aws:s3:::${self:provider.environment.COMPANY_ABBREVIATION}-lara-frontend-${self:custom.stage}/*'
Condition:
StringEquals:
AWS:SourceArn: !Sub arn:aws:cloudfront::${AWS::AccountId}:distribution/${FrontendDistribution.Id}
aws:SourceArn: !Sub 'arn:aws:cloudfront::${AWS::AccountId}:distribution/${FrontendDistribution.Id}'

FrontendBucketPolicy:
Type: AWS::S3::BucketPolicy
Properties:
Bucket: !Ref FrontendBucket
PolicyDocument:
Version: '2012-10-17'
Statement:
- Sid: 'AllowSSLRequestsOnly'
Effect: Deny
Principal: '*'
Action: 's3:*'
Resource:
- !Sub 'arn:aws:s3:::${FrontendBucket}'
- !Sub 'arn:aws:s3:::${FrontendBucket}/*'
Condition:
Bool:
'aws:SecureTransport': 'false'

AttachmentsBucketPolicy:
Type: AWS::S3::BucketPolicy
Properties:
Bucket: !Ref AttachmentsBucket
PolicyDocument:
Version: '2012-10-17'
Statement:
- Sid: 'AllowSSLRequestsOnly'
Effect: Deny
Principal: '*'
Action: 's3:*'
Resource:
- !Sub 'arn:aws:s3:::${AttachmentsBucket}'
- !Sub 'arn:aws:s3:::${AttachmentsBucket}/*'
Condition:
Bool:
'aws:SecureTransport': 'false'