Skip to content

Conversation

@R3VoLuT1OneR
Copy link
Contributor

Hey I just found small "syntax" errors in "doctrine:convert:mapping" command.

Please merge the fix.

@patrickbrouwers
Copy link
Contributor

Please re-add the = to --from-database

@R3VoLuT1OneR
Copy link
Contributor Author

R3VoLuT1OneR commented Apr 29, 2016

@patrickbrouwers If remove it, code $this->option('from-database') === true never be true.

--from-database - Without = parsed as boolean ( set or not set ) and --form-database= parsed always as string. Because here we have option set/not set and no value required I think should be used --form-data.

@R3VoLuT1OneR
Copy link
Contributor Author

@patrickbrouwers And in original doctrine command it is --from-database without =

@patrickbrouwers
Copy link
Contributor

Ah I was in the impression you could pass the database name to that option.

@patrickbrouwers patrickbrouwers merged commit 6a3a074 into laravel-doctrine:1.1 Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants