Skip to content

Conversation

@fureszpeter
Copy link
Contributor

Changes proposed in this pull request:

Important Notes

Since Laravel support only one slave (read-only) connection, not completely compatible with Laravel database.php

Differences:

_Doctrine version:_

            'read' => [
                [ //<==Please note, we need to add multiple arrays here!
                    'host' => env('DB_HOST_R', 'localhost'),
                    'database' => env('DB_DATABASE_R', ''),
                    'username' => env('DB_USERNAME_R', ''),
                    'password' => env('DB_PASSWORD_R', ''),
                ],
            ],

_Laravel version:_

            'read' => [
                    'host' => env('DB_HOST_R', 'localhost'),
                    'database' => env('DB_DATABASE_R', ''),
                    'username' => env('DB_USERNAME_R', ''),
                    'password' => env('DB_PASSWORD_R', ''),
            ],

Peter Furesz added 3 commits June 13, 2016 16:15
 - Handling read / write connections
 - Cache settings to avoid read and parse config files if it's done already.

 (note: if same settings are provided, we always return the as well configured EntityManager . Don't need to re-create / re-parse configs)
@patrickbrouwers
Copy link
Contributor

Need some time to properly test this, so it doesn't break any existing functionality.

@guiwoda
Copy link
Contributor

guiwoda commented Jun 17, 2016

@fureszpeter Could you separate your EM config change from your read-write change?
I think they could be merged individually.

@patrickbrouwers
Copy link
Contributor

Replaced by #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants