Skip to content

Conversation

@guiwoda
Copy link
Contributor

@guiwoda guiwoda commented Dec 19, 2016

Alternative Pagination traits to (sort of) decouple from Laravel's Request.
Two Traits were introduced: PaginatesFromRequest and PaginatesFromParams. The previous Paginatable trait was kept for backwards compatilibility, but PaginatesFromRequest should be favored.

TO DO:
See if doctrine/orm#6180 passes so we can actually unit test this.

@guiwoda
Copy link
Contributor Author

guiwoda commented Jan 4, 2017

@patrickbrouwers Do you think we could integrate this as is, then somewhere along the road add database integration tests for it?

@patrickbrouwers patrickbrouwers merged commit 15287c7 into laravel-doctrine:1.2 Jan 17, 2017
@zdnk
Copy link

zdnk commented Jan 18, 2017

will you update the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants