[FIX] Presence verifier on lumen #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes #202 |
|
Is there a chance of merge this PR? |
patrickbrouwers
requested changes
Mar 28, 2017
| * Register the validation factory. | ||
| * | ||
| * @return void | ||
| */ |
Contributor
There was a problem hiding this comment.
Is it necessary to redeclare this if we are extending ValidationServiceProvider ?
Contributor
Author
There was a problem hiding this comment.
Yes, the default implementation checks for different unrelated conditions before calling $validator->setPresenceVerifier
patrickbrouwers
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
PresenceVerifierProviderto account for the removal of the default 'validator' binding (if wanting to use doctrine presence)ValidationServiceProviderhas a db instance to use when checking to see if it should set the presence verifier (when using the default presence)