Skip to content

Conversation

@sztyup
Copy link
Contributor

@sztyup sztyup commented Feb 17, 2018

Changes proposed in this pull request:

  • Use the recently relased 2.6 version of the doctrine ORM which has many improvements.

@patrickbrouwers
Copy link
Contributor

@sztyup how well did you test this in your own app/a test app? Does everything still work, no changes on doctrine side that break anything on our side?

@sztyup
Copy link
Contributor Author

sztyup commented Feb 17, 2018

@patrickbrouwers I tested it on two of my own apps and as far as I can tell nothing breaks

@sztyup
Copy link
Contributor Author

sztyup commented Feb 17, 2018

Here are the possible BC breaks from the update, the only important is the php7.1 requirement, which should to be documented here too.
EDIT: I realized its better than that, for users with 7.0 it sticks with orm 2.5 and for 7.1 it updates to 2.6
https://github.com/doctrine/doctrine2/releases/tag/v2.6.0

@xtrasmal
Copy link

Can we update?
I really like to use https://github.com/Ocramius/DoctrineBatchUtils which uses orm 2.6

@patrickbrouwers patrickbrouwers changed the base branch from 1.4 to 1.5 February 27, 2018 11:26
@patrickbrouwers patrickbrouwers changed the base branch from 1.5 to 1.4 February 27, 2018 12:20
@patrickbrouwers patrickbrouwers merged commit f5a7a62 into laravel-doctrine:1.4 Feb 27, 2018
@patrickbrouwers
Copy link
Contributor

Thanks for the PR, installing with 2.6 should be possible now. Will indeed install 2.5 if you are using <7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants