[FIX] Trying to print_r circular entity dependency results in OOM in InteractsWithEntities #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies. 2. simple tests for InteractsWithEntities
Contributor
|
Thanks! :) |
DemianShtepa
added a commit
to DemianShtepa/orm
that referenced
this pull request
Dec 28, 2022
1.7.13 - Hashing password-reset tokens before storing (laravel-doctrine#508 laravel-doctrine#506) @rosamarsky - Trying to print_r circular entity dependency results in OOM in InteractsWithEntities (laravel-doctrine#510) @k0ka Breaking change: - All password reset tokens will be invalidated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
InteractsWithEntitiestrait hasentitiesMatch/noEntitiesMatchassertions which accept criteria as an argument. This criteria might contain other entities: for example if we are searching by aManyToOnerelation. The code outputs criteria inprint_r. But in a complex setup whereentityAhas the relation toentityBandentityBhas the relation toentityAthis may end up with a circular dependency and fail with the PHP errorAllowed memory size of X bytes exhaustedChanges proposed in this pull request:
criteriainInteractsWithEntitiesare replaced by their ids.InteractsWithEntities