Skip to content

feat: generate resource toArray for non-hidden columns #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

feat: generate resource toArray for non-hidden columns #117

merged 1 commit into from
Apr 16, 2020

Conversation

ghostwriter
Copy link
Contributor

Close #94

@jasonmccreary
Copy link
Collaborator

Thanks for taking the extra time to clean this up. Been swamped with PRs this week, so having a smaller set of files to review makes it easier.

I think I'm going to refactor modelForContext in tomorrow's live stream. It's not used in multiple generators and needed in more for some of the open issues.

@jasonmccreary jasonmccreary merged commit 1258a99 into laravel-shift:master Apr 16, 2020
@ghostwriter ghostwriter deleted the feature/resource-non-hidden-columns-toarray branch April 16, 2020 19:08
@ghostwriter ghostwriter mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate Resource data based on Model
2 participants
@ghostwriter @jasonmccreary