feat: ability to customize pivot table columns (belongsToMany) #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmccreary
requested changes
May 20, 2020
src/Generators/ModelGenerator.php
Outdated
| $relationship = ""; | ||
| if (!is_null($class) && $type === 'belongsToMany') { | ||
| if (preg_match("/^[A-Z]/", $name)) { | ||
| $relationship = sprintf("\$this->%s(%s::class)->using(%s::class)", $type, '\\' . $model->fullyQualifiedNamespace() . '\\' . $relationShipClass, '\\' . $model->fullyQualifiedNamespace() . '\\' . $name); |
There was a problem hiding this comment.
Please use single quote for all strings.
src/Generators/ModelGenerator.php
Outdated
|
|
||
| $relationship = ""; | ||
| if (!is_null($class) && $type === 'belongsToMany') { | ||
| if (preg_match("/^[A-Z]/", $name)) { |
There was a problem hiding this comment.
It's not clear that this preg_match determines if the developer passed a model reference.
I am open to supporting this. But I feel there are more implications (e.g. generating the pivot model). For now, I think we should focus on the original issue, which was specifying the custom table name.
Said another way, let's assume, for now, that whatever they pass is a custom table name.
|
Ok, tomorrow I will update the pull request with the requested changes. |
|
@Pr3d4dor, no rush. Thanks. |
…om:Pr3d4dor/blueprint into feature/ability-to-customize-pivot-columns
This was referenced May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to customize pivot table columns (belongsToMany).
Closes #175