config: update pint.json to use laravel pckage rules #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
One thing I’m not sure about with this is the CI because we used the
package template to create Boost initially, it uses other templates for
style checking in .GitHub/workflows
Will take a proper look shortly 👌
Ashley Hindle | Senior Software Engineer
***@***.***
www.laravel.com
…On Fri, 8 Aug 2025 at 07:52, Pushpak Chhajed ***@***.***> wrote:
@pushpak1300 <https://github.com/pushpak1300> requested your review on: #5
<#5> config: update pint.json to use
laravel pckage rules.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPCP4AN5HTMXV6UVABQZD3MRCKPAVCNFSM6AAAAACDNAHCJSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJZGA2DQNRSGI2TSMI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
Author
|
CI Pipelines are failing mainly because of the package issue. taking the look |
Collaborator
Looking at the workflow, it loads in style checking like this: And that just runs pint with no config options: So it should be fine, if this pint config is better |
ashleyhindle
approved these changes
Aug 8, 2025
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR add changes to Pint config.
The pint config has been copied form https://github.com/laravel/framework