[5.8] Add #25517 and #25732 to upgrade guide #4554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this sentence needs more explanation: "The query builder now supports JSON queries on MariaDB. This changes the name of columns without an alias:". I don't know what that means. |
staudenmeir
force-pushed
the
upgrade
branch
from
67c6a32 to
b481f98
Compare
|
I updated the example to make it clearer. It's more of a theoretical breaking change, I hope nobody accesses attributes this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4553:
laravel/framework#25732:
If you are manually unquoting JSON values (
json_decode('"en"')), this will no longer work.laravel/framework#25517:
If you are accessing JSON values with
$user->{'`options`->\'$."language"\''}, this will no longer work.Can you please not close PRs with a question? I and others find this disrespectful and discouraging. I understand that you don't read closed PRs, just leave the PR open for a day and give the contributor time to respond. Opening a new PR to answer a question is really not a pleasant and efficient way of communicating.