Skip to content

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Sep 3, 2021

Adding this note will inform users to review Meilisearch breaking changes when they update their Meilisearch binary.

This also contains a note about compatibility between meilisearch-php and the meilisearch binary.

See laravel/scout#516

@driesvints driesvints changed the title [9.x] Add Meilisearch upgrade note to Scout docs [8.x] Add Meilisearch upgrade note to Scout docs Sep 3, 2021
@georgeboot
Copy link

Perhaps we should also include something about compatibility between the meilisearch-php and the server? For example, composer installs latest meilisearch-php but brew install meilisearch on MacOS will install 0.20.0, which will now break.

@driesvints
Copy link
Member Author

Isn't scout now compatible with all Meilisearch versions? I thought your PR with the version check did just that.

@georgeboot
Copy link

The whole thing is that if you have meilisearch server 0.21 and meilisearch-php 0.19, you are fine. Scout handles that. This is also the correct setup.

However, a (new) user might simple install the latest versions of everything. This will mostly go correct, but for example on Homebrew, 0.21 isn't available, and now you are getting a super strange error.

Users need to install the correct sdk version for the server version they have.

Probably super niche, so not worth a note in the docs, but felt I should at least share so you can make a decision on it.

@driesvints
Copy link
Member Author

@georgeboot that's a good remark, thanks for noting that. Can you maybe send in a PR to my PR for a proposal? Or just comment here how you'd note it?

@georgeboot
Copy link

I would add the following in the docs under the driver prerequisites section, directly under the composer install for meili:

Make sure you install a version of meilisearch/meilisearch-php that is compatible with your server version. You can check compatibility here.

@driesvints
Copy link
Member Author

Thanks @georgeboot. I added that albeit a bit lower.

@taylorotwell taylorotwell merged commit b2555c6 into 8.x Sep 3, 2021
@driesvints driesvints deleted the driesvints-patch-1 branch September 3, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants