Skip to content

Conversation

@asbiin
Copy link
Contributor

@asbiin asbiin commented Jan 18, 2020

Update jQuery file using the min version here.

The current jQuery file is the slim build: this version does not include the animate function required to use scrollTo function.

@browner12
Copy link
Contributor

similar to how we only allow Laravel employees to update the Chrome Drivers, can we restrict updating this asset to employees as well? It would be too easy for a malicious actor to sneak some code into this due to the size of the change.

Or at a minimum have the employee comment they have confirmed the asset is unaltered from the source, prior to merging?

FWIW, I compared this with the Jquery download page and it looks 👍 .

https://code.jquery.com/jquery-3.4.1.min.js

@asbiin asbiin deleted the update-jquery-version branch January 21, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants