[1.x] chore: bump to pragmarx/google2fa v9 #619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency
pragmarx/google2fato v9. This version contains a breaking change: the default secret key length has been increased from 16 to 32 characters for enhanced security. However, Laravel Fortify explicitly sets the default value for the generation of a secret key to 16:fortify/src/TwoFactorAuthenticationProvider.php
Lines 44 to 47 in bd38202
Therefore, bumping to v9 is not a breaking change for Laravel Fortify.
In theory we could set the value to 32 as well, as in the migration the field
two_factor_secretis of type TEXT so an increase in the length of the secret would not be an issue but there might be other side effects as well as mentioned in the release notes ofpragmarx/google2fa. Such a change would be better for in a future 2.x-release.