Translator contract is not respected by the blade complier

[jeanmonod]

• Laravel Version: v5.5.32
• PHP Version: all

Description:

Here:

framework/src/Illuminate/View/Compilers/Concerns/CompilesTranslations.php

Line 21 in 56a58e0

return "<?php echo app('translator')->getFromJson{$expression}; ?>";

The blade compiler is bypassing the translator interface. Ihmo it should call trans() instead of getFromJson

Steps To Reproduce:

Implement our own Translator service following the official interface:

use Illuminate\Contracts\Translation\Translator as TranslatorContract;
class Translator implements TranslatorContract
{
    public function trans($key, array $replace = [], $locale = null) { ... }
    public function transChoice($key, $number, array $replace = [], $locale = null) { ... }
    public function getLocale() { ... }
    public function setLocale($locale) { ... }
}

Start to use it and get the following error:

Call to undefined method MyProject\Libraries\Translation\Translator::getFromJson() (View: /vagrant/resources/views/components/my-block.blade.php)

Disclamer

I'm just starting to use Laravel, so I may be wrong. All my apologies if it's the case

[ntzm]

A lot of the interfaces are out of date due to features being added as new functions in minor releases, and changing the interface would result in a breaking change. If you can submit a PR to add the missing methods to the interface that targets the master branch, it can be added next BC break

[jeanmonod]

I won't do this. It make no sense. The interface is clean as it is. I'm fetching translations from a key-value database, what do you want me to implement into getFromJson? For now, I stupidely fix my issue by surcharging the method like this:

// Overriding this method to fix https://github.com/laravel/framework/issues/23162
public function getFromJson($key, array $replace = [], $locale = null) {
    return $this->trans($key, $replace, $locale);
}

For me it's not a blocker anymore, but honestly, I think you should fix it the other way around, calling trans() from the blade templates. Do you want a PR for that fix?

[tillkruss]

Sure, please feel free to submit a PR.

[raphaelsaunier]

@tillkruss I submitted a PR which would've addressed this issue (see link above), but it was closed by Taylor.

I'm happy to look into it again if you see any other ways to solve it?

[tillkruss]

I'd suggest to either add your own @trans directive, or even submit a PR for it.

I've closed this because it's not a bug.