Skip to content

Conversation

X-Coder264
Copy link
Contributor

As #25152 which contained two changes unfortunately didn't get merged I created this PR which contains only the first change of that PR.

  1. In ValidatesWhenResolvedTrait the passes method was called on a \Illuminate\Contracts\Validation\Validator instance even though the passes method doesn't exist on the interface. This was adjusted to call the fails method which is present on the interface and thus I avoided making a breaking change (adding the passes method to the interface).

@taylorotwell taylorotwell merged commit 49db8de into laravel:5.7 Aug 9, 2018
@X-Coder264 X-Coder264 deleted the call-proper-validator-interface-method branch August 9, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants