[9.x] Remove static return types
#41276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would definitely like a second set of eyes on this, but I'm pretty sure these methods will only return instances of the Eloquent or Query Builder. It was a little difficult to find how these methods are called, but it's in the
\Illuminate\Database\Eloquent\SoftDeletingScope.The reason I came across this was that I was trying to select trashed Eloquent models on a specific database connection.
This doesn't actually work, but the IDE thinks it's okay, because it sees
withTrashed()returningstatic, which is\App\Userwhich extends the\Illuminate\Database\Eloquent\Model, which does have theon()method.In reality, it returns the
\Illuminate\Database\Eloquent\Builderwhich does not have theon()method.