Skip to content

Conversation

@hans-thomas
Copy link
Contributor

@hans-thomas hans-thomas commented Sep 25, 2023

It fixes incompatible errors in Laravel after upgrading to Symfony:7.0.
There are still 20 errors in the tests. Can I help to fix the errors?

@hans-thomas hans-thomas marked this pull request as ready for review September 25, 2023 14:41
@driesvints
Copy link
Member

Hi there, thanks but we already have a PR up and are planning to tackle this internally.

#48403

@driesvints driesvints closed this Sep 25, 2023
@driesvints
Copy link
Member

@hans-thomas if you want, you can PR the pr above

@hans-thomas
Copy link
Contributor Author

hans-thomas commented Sep 25, 2023

@hans-thomas if you want, you can PR the pr above

@driesvints I love to but I don't get it 😅 what do you mean by that?
Should I clone the laravel/framework repo and commit changes to the symfony7 branch?

@Jubeki
Copy link
Contributor

Jubeki commented Sep 26, 2023

@hans-thomas I think you did the right thing as you are already targeting the symfony7 branch with this PR.

Maybe @driesvints can check this PR again. (Though symfony7 will probably be rebased against master first, to fix some other tests)

@driesvints
Copy link
Member

@Jubeki think the branch was changed after I closed the PR because it was first targetting master.

@driesvints driesvints reopened this Sep 26, 2023
@driesvints
Copy link
Member

Thanks @hans-thomas. Right now I don't have the time to look into this PR to see if everything seems in order. I'll leave this open to review at a later moment.

@driesvints driesvints marked this pull request as draft September 26, 2023 16:17
@hans-thomas
Copy link
Contributor Author

Too late to review. It's already done in symfony7 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants