Skip to content

[10.x] Fixes Illuminate\Support\Str::fromBase64() return type #50108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2024
Merged

[10.x] Fixes Illuminate\Support\Str::fromBase64() return type #50108

merged 1 commit into from
Feb 16, 2024

Conversation

SamAsEnd
Copy link
Contributor

base64_decode returns a string

@crynobone crynobone changed the title Minor typo [10.x] Fixes Illuminate\Support\Str::fromBase64() return type Feb 16, 2024
@driesvints driesvints merged commit 7784c1b into laravel:10.x Feb 16, 2024
@driesvints
Copy link
Member

Thanks!

@GrahamCampbell
Copy link
Member

This is actually not correct. This function return false on failure. The correct return type is string|false.

@driesvints
Copy link
Member

@GrahamCampbell can you PR?

itinerare pushed a commit to itinerare/Alcyone that referenced this pull request Feb 26, 2024
chore(deps): update dependency laravel/framework to v10.45.1 (!5)
307f2dc 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [laravel/framework](https://laravel.com) ([source](https://github.com/laravel/framework)) | require | minor | `10.44.0` -> `10.45.1` |

---

### Release Notes

<details>
<summary>laravel/framework (laravel/framework)</summary>

### [`v10.45.1`](https://github.com/laravel/framework/blob/HEAD/CHANGELOG.md#v10451---2024-02-21)

[Compare Source](laravel/framework@v10.45.0...v10.45.1)

-   Fix typehint for ResetPassword::toMailUsing() by [@&#8203;KKSzymanowski](https://github.com/KKSzymanowski) in laravel/framework#50163
-   \[10.x] Fix Process::fake() never matching multi-line commands by [@&#8203;SjorsO](https://github.com/SjorsO) in laravel/framework#50164

### [`v10.45.0`](https://github.com/laravel/framework/blob/HEAD/CHANGELOG.md#v10450---2024-02-20)

[Compare Source](laravel/framework@v10.44.0...v10.45.0)

-   \[10.x] Update `Stringable` phpdoc by [@&#8203;milwad-dev](https://github.com/milwad-dev) in laravel/framework#50075
-   \[10.x] Allow `Collection::select()` to work on `ArrayAccess` by [@&#8203;axlon](https://github.com/axlon) in laravel/framework#50072
-   \[10.x] Add `before` to the `PendingBatch` by [@&#8203;xiCO2k](https://github.com/xiCO2k) in laravel/framework#50058
-   \[10.x] Adjust rules call sequence by [@&#8203;driesvints](https://github.com/driesvints) in laravel/framework#50084
-   \[10.x] Fixes `Illuminate\Support\Str::fromBase64()` return type by [@&#8203;SamAsEnd](https://github.com/SamAsEnd) in laravel/framework#50108
-   \[10.x] Actually fix fromBase64 return type by [@&#8203;GrahamCampbell](https://github.com/GrahamCampbell) in laravel/framework#50113
-   \[10.x] Fix warning and deprecation for Str::api by [@&#8203;driesvints](https://github.com/driesvints) in laravel/framework#50114
-   \[10.x] Mark model instanse as not exists on deleting MorphPivot relation. by [@&#8203;dkulyk](https://github.com/dkulyk) in laravel/framework#50135
-   \[10.x] Adds Tappable and Conditionable to Relation class by [@&#8203;DarkGhostHunter](https://github.com/DarkGhostHunter) in laravel/framework#50124
-   \[10.x] Added getQualifiedMorphTypeName to MorphToMany by [@&#8203;dkulyk](https://github.com/dkulyk) in laravel/framework#50153

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTQuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxNC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Reviewed-on: https://code.itinerare.net/itinerare/Alcyone/pulls/5
Co-authored-by: Amadeus[bot] <amadeus@itinerare.net>
Co-committed-by: Amadeus[bot] <amadeus@itinerare.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crynobone crynobone crynobone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamAsEnd @driesvints @GrahamCampbell @crynobone