Fix typehint for ResetPassword::toMailUsing() #50163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type hint the
$callback
parameter inResetPassword::toMailUsing()
seems to be too narrow - it declares that the Closure must return an instance ofMailMessage
and nothing else. However an instance ofMailable
is perfectly acceptable in this case as it goes throughMailChannel::send()
which has a special case for$message instanceof Mailable
.This triggers the following error eg. in phpstan:
I believe the type hint should be corrected to include
Mailable
as an acceptable Closure return type.