Skip to content

Conversation

@Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Sep 4, 2024

WIP.

Seems like I missed some constraints for PHPunit 10. I will also update the composer.json files afterwards.

I don't think that nesbot/carbon:^2 will support PHP 8.4 based on the releases.
(If I remember correctly the Plan is to drop carbon v2 in Laravel 12 right?)

Pull Requests on other repositories:

@github-actions
Copy link

github-actions bot commented Sep 4, 2024

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@Jubeki
Copy link
Contributor Author

Jubeki commented Sep 4, 2024

After this PR:

Phpunit 10 - lowest: Errors: 10, Failures: 8, Deprecations: 134
Phpunit 10 - stable: Errors: 9, Failures: 8, Deprecations: 68
Phpunit 11 - lowest: Errors: 10, Failures: 8, Deprecations: 134
Phpunit 11 - stable: Errors: 9, Failures: 8, Deprecations: 68

I assume many errors to be with the lower bounds of some other libraries.

@Jubeki Jubeki marked this pull request as ready for review September 4, 2024 09:11
@taylorotwell taylorotwell marked this pull request as draft September 4, 2024 14:10
@taylorotwell
Copy link
Member

Am I supposed to merge this? Just mark as ready for review if so. 👍

@Jubeki
Copy link
Contributor Author

Jubeki commented Sep 4, 2024

Should be okay to be merged, you can also leave the decision to @driesvints for further review. The final PR #52633 with the PHP8.4 build is still WIP.

@Jubeki Jubeki marked this pull request as ready for review September 5, 2024 06:33
@driesvints driesvints merged commit a156002 into laravel:php84 Sep 5, 2024
@driesvints
Copy link
Member

Thanks @Jubeki

@Jubeki Jubeki deleted the php84-update-dependencies branch September 5, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants