Skip to content

Conversation

@cosmastech
Copy link
Contributor

This restores the factories on the Str class to their defaults when tearing down test cases. I can't think of a reason this would really be a breaking change, but happy to be corrected.

@taylorotwell
Copy link
Member

@cosmastech could someone be faking the str generation in a setUp method or something which this would break?

@cosmastech
Copy link
Contributor Author

cosmastech commented Oct 7, 2025

@cosmastech could someone be faking the str generation in a setUp method or something which this would break?

@taylorotwell, not exactly. The setUp runs before every test, but they could have it modified in setUpBeforeClass() or something. Or they could have written their tests with the expectation that modifying it in one case will always keep that going forward.

I can target master for this if you're ok with the change, but just want to avoid a BC on a minor version.

Could also probably call Str::flushCache() here.

@taylorotwell
Copy link
Member

Yeah I think since it could be a breaking change can't do it on 12.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants