Skip to content

Conversation

Rakib01
Copy link
Contributor

@Rakib01 Rakib01 commented Oct 13, 2025

Adds support for JetBrains Fleet editor in the ResolvesDumpSource.

@Rakib01
Copy link
Contributor Author

Rakib01 commented Oct 13, 2025

  • Add support for Fleet editor in ResolvesDumpSource
  • Fix PHPStan undefined variable errors in FailoverQueue

PHPStan was reporting "Variable $e might not be defined" in FailoverQueue. This occurred
because the exception variable was only set within the catch block,
creating a code path where it might be undefined when thrown.

Resolved by:

  • Renaming $e to $lastException for clarity
  • Initializing $lastException to null before the loop
  • Using the null coalescing operator to throw either the last exception
    or a RuntimeException

@taylorotwell taylorotwell merged commit 627bb64 into laravel:12.x Oct 13, 2025
64 checks passed
@taylorotwell
Copy link
Member

This is the last one I'm doing for a while 😅

@Rakib01
Copy link
Contributor Author

Rakib01 commented Oct 14, 2025

Haha, totally understand! Thanks for merging this one 😊

@Rakib01 Rakib01 deleted the add-fleet-editor-support branch October 14, 2025 03:18
@ahmad-cit22
Copy link
Contributor

  • Renaming $e to $lastException for clarity
  • Initializing $lastException to null before the loop
  • Using the null coalescing operator to throw either the last exception
    or a RuntimeException

Liked this part of your PR 👏 replacing the redundant throw of $e; with predefined $lastException..this makes the failover logic much cleaner and safer. Keep it up bro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants