Only replace first basePath occurrence in dump source href #57458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a custom value for
config('app.editor.base_path')
, you can essentially map a local path (inside a docker container in my case) to a path that exists on the dev's machine so they can open it in their editor. However, with the existing code, if my base path in the container is, say,/app
, and the path I'm trying to get the source href to has that path duplicated, like with/app/app/Models/User.php
, I'll end up with both instances of the base path mapped over to the custom base path (e.g.,/my-project/my-project/Models/User.php
ifconfig('app.editor.base_path')
is/my-project
).This PR just makes the path replacement more limited to avoid that issue.