Skip to content

[12.x] Correct Response namespace in Batch #57481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
+9 −9
Merged

[12.x] Correct Response namespace in Batch #57481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/Illuminate/Http/Client/Batch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,28 +68,28 @@ class Batch
/**
* The callback to run after a request from the batch succeeds.
*
* @var (\Closure($this, int|string, \Illuminate\Http\Response): void)|null
* @var (\Closure($this, int|string, \Illuminate\Http\Client\Response): void)|null
*/
protected $progressCallback = null;

/**
* The callback to run after a request from the batch fails.
*
* @var (\Closure($this, int|string, \Illuminate\Http\Response|\Illuminate\Http\Client\RequestException|\Illuminate\Http\Client\ConnectionException): void)|null
* @var (\Closure($this, int|string, \Illuminate\Http\Client\Response|\Illuminate\Http\Client\RequestException|\Illuminate\Http\Client\ConnectionException): void)|null
*/
protected $catchCallback = null;

/**
* The callback to run if all the requests from the batch succeeded.
*
* @var (\Closure($this, array<int|string, \Illuminate\Http\Response>): void)|null
* @var (\Closure($this, array<int|string, \Illuminate\Http\Client\Response>): void)|null
*/
protected $thenCallback = null;

/**
* The callback to run after all the requests from the batch finish.
*
* @var (\Closure($this, array<int|string, \Illuminate\Http\Response>): void)|null
* @var (\Closure($this, array<int|string, \Illuminate\Http\Client\Response>): void)|null
*/
protected $finallyCallback = null;

Expand Down Expand Up @@ -161,7 +161,7 @@ public function before(Closure $callback): self
/**
* Register a callback to run after a request from the batch succeeds.
*
* @param (\Closure($this, int|string, \Illuminate\Http\Response): void) $callback
* @param (\Closure($this, int|string, \Illuminate\Http\Client\Response): void) $callback
* @return Batch
*/
public function progress(Closure $callback): self
Expand All @@ -174,7 +174,7 @@ public function progress(Closure $callback): self
/**
* Register a callback to run after a request from the batch fails.
*
* @param (\Closure($this, int|string, \Illuminate\Http\Response|\Illuminate\Http\Client\RequestException|\Illuminate\Http\Client\ConnectionException): void) $callback
* @param (\Closure($this, int|string, \Illuminate\Http\Client\Response|\Illuminate\Http\Client\RequestException|\Illuminate\Http\Client\ConnectionException): void) $callback
* @return Batch
*/
public function catch(Closure $callback): self
Expand All @@ -187,7 +187,7 @@ public function catch(Closure $callback): self
/**
* Register a callback to run after all the requests from the batch succeed.
*
* @param (\Closure($this, array<int|string, \Illuminate\Http\Response>): void) $callback
* @param (\Closure($this, array<int|string, \Illuminate\Http\Client\Response>): void) $callback
* @return Batch
*/
public function then(Closure $callback): self
Expand All @@ -200,7 +200,7 @@ public function then(Closure $callback): self
/**
* Register a callback to run after all the requests from the batch finish.
*
* @param (\Closure($this, array<int|string, \Illuminate\Http\Response>): void) $callback
* @param (\Closure($this, array<int|string, \Illuminate\Http\Client\Response>): void) $callback
* @return Batch
*/
public function finally(Closure $callback): self
Expand All @@ -223,7 +223,7 @@ public function defer(): DeferredCallback
/**
* Send all of the requests in the batch.
*
* @return array<int|string, \Illuminate\Http\Response|\Illuminate\Http\Client\RequestException>
* @return array<int|string, \Illuminate\Http\Client\Response|\Illuminate\Http\Client\RequestException>
*/
public function send(): array
{
Expand Down