Skip to content

[12.x] Ensure HTTP batch results are returned in the same order as requested #57483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
+8 −0
Merged

[12.x] Ensure HTTP batch results are returned in the same order as requested #57483

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cfad7e
Ensure HTTP Batch results are returned in the same order as requested
jessarcher Oct 22, 2025
3f29f2b
Update Batch.php
taylorotwell Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Illuminate/Http/Client/Batch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,14 @@ public function send(): array
]))->promise()->wait();
}

// Before returning the results, we must ensure that the results are sorted
// in the same order as the requests were defined, respecting any custom
// key names that were assigned to this request using the "as" method.
uksort($results, function ($key1, $key2) {
return array_search($key1, array_keys($this->requests), true) <=>
array_search($key2, array_keys($this->requests), true);
});

if (! $this->hasFailures() && $this->thenCallback !== null) {
call_user_func($this->thenCallback, $this, $results);
}
Expand Down