[12.x] Emit underlying store name in cache events when using failover #57505
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the failover cache, currently the cache events have a null
storeName:This is because the failover config is not currently passed to the
Illuminate\Cache\Respositoryinstance.However, if we were to just pass the config, then the events would have the name
failover, which I don't think is ideal:Instead, this PR disables events for the repository that wraps the
FailoverStorestore, and modifies it to call the underlying repositories, instead of the underlying stores, so that cache events are emitted with the underlying store name:This is similar to the
MemoizedStorewhich also disables events for itself, and calls the underlying repository, rather than the underlying store.