Skip to content

[12.x] Add missing @throws annotation #57535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2025
+19 −0
Merged

[12.x] Add missing @throws annotation #57535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7525b94
Update Repository.php
AhmedAlaa4611 Oct 25, 2025
cfc7da7
Update PacksPhpRedisValues.php
AhmedAlaa4611 Oct 25, 2025
5f256da
Update SymfonySessionDecorator.php
AhmedAlaa4611 Oct 25, 2025
2e9a785
Re-run tests
AhmedAlaa4611 Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Illuminate/Config/Repository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ public function getMany($keys)
* @param string $key
* @param (\Closure():(string|null))|string|null $default
* @return string
*
* @throws \InvalidArgumentException
*/
public function string(string $key, $default = null): string
{
Expand All @@ -104,6 +106,8 @@ public function string(string $key, $default = null): string
* @param string $key
* @param (\Closure():(int|null))|int|null $default
* @return int
*
* @throws \InvalidArgumentException
*/
public function integer(string $key, $default = null): int
{
Expand All @@ -124,6 +128,8 @@ public function integer(string $key, $default = null): int
* @param string $key
* @param (\Closure():(float|null))|float|null $default
* @return float
*
* @throws \InvalidArgumentException
*/
public function float(string $key, $default = null): float
{
Expand All @@ -144,6 +150,8 @@ public function float(string $key, $default = null): float
* @param string $key
* @param (\Closure():(bool|null))|bool|null $default
* @return bool
*
* @throws \InvalidArgumentException
*/
public function boolean(string $key, $default = null): bool
{
Expand All @@ -164,6 +172,8 @@ public function boolean(string $key, $default = null): bool
* @param string $key
* @param (\Closure():(array<array-key, mixed>|null))|array<array-key, mixed>|null $default
* @return array<array-key, mixed>
*
* @throws \InvalidArgumentException
*/
public function array(string $key, $default = null): array
{
Expand Down
3 changes: 3 additions & 0 deletions src/Illuminate/Redis/Connections/PacksPhpRedisValues.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ trait PacksPhpRedisValues
*
* @param array<int|string,string> $values
* @return array<int|string,string>
*
* @throws \RuntimeException
* @throws \UnexpectedValueException
*/
public function pack(array $values): array
{
Expand Down
6 changes: 6 additions & 0 deletions src/Illuminate/Session/SymfonySessionDecorator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ public function isStarted(): bool

/**
* {@inheritdoc}
*
* @throws \BadMethodCallException
*/
public function registerBag(SessionBagInterface $bag): void
{
Expand All @@ -169,6 +171,8 @@ public function registerBag(SessionBagInterface $bag): void

/**
* {@inheritdoc}
*
* @throws \BadMethodCallException
*/
public function getBag(string $name): SessionBagInterface
{
Expand All @@ -177,6 +181,8 @@ public function getBag(string $name): SessionBagInterface

/**
* {@inheritdoc}
*
* @throws \BadMethodCallException
*/
public function getMetadataBag(): MetadataBag
{
Expand Down