[12.x] Use match expression for Console's QuestionHelper #57563
Closed
+25
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that PRs like #57552 and #57236 were recently merged, where similar refactors replaced I created this PR for the same reason because I saw you seemed to like that cleaner approach and wanted to help modernize other parts of the codebase as well. Could you please let me know if there’s anything wrong with my PR or if this kind of change just isn’t desired here? I’d appreciate any feedback so I can align future contributions better. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I replaced the switch with match expression for Console's QuestionHelper.