Skip to content

Conversation

@kichetof
Copy link
Contributor

@kichetof kichetof commented Nov 6, 2025

This PR add missing separators to Stringable::ucwords introduced in #57581 that allow custom separators when chaining.

Use case:

Str::of('LARAVEL-Framework')->lower()->ucwords('-'); // Laravel-Framework

I added related tests to StringableTest

@kichetof
Copy link
Contributor Author

kichetof commented Nov 6, 2025

test failure seem to be not related with my PR

There was 1 failure:

1) Illuminate\Tests\Support\SupportStrTest::testWhetherTheNumberOfGeneratedCharactersIsEquallyDistributed
Failed asserting that 9496 matches expected 10000.

/home/runner/work/framework/framework/tests/Support/SupportStrTest.php:807

FAILURES!
Tests: 12348, Assertions: 37014, Failures: 1, Warnings: 1, Skipped: 481.
Error: Process completed with exit code 1.

@taylorotwell taylorotwell merged commit 8cc0f32 into laravel:12.x Nov 6, 2025
65 of 66 checks passed
@kichetof kichetof deleted the patch-stringable-ucwords branch November 6, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants