-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[12.x] Add encoding validation rule for uploaded files
#57823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+102
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Would it make sense to have a |
Contributor
Author
|
@shaedrich I was trying to keep things as simple as possible here. |
Member
|
Is this rule actually specific to files or is it just for any string? |
Contributor
Author
|
@taylorotwell It works for both files and strings. |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
encodingvalidation rule that checks the contents of a file matches a specific encoding usingmb_check_encoding(). In my case I want to ensure user uploaded files such as spreadsheets from office suite software is actually UTF-8, so it can be safely processed.It can be used as a typical validation:
['file', 'encoding:utf-8']or via the file rule builder:File::rule()->encoding('utf-8'). It also works for strings.