[12.x] Allow CachedState properties to be nullable #57826
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
WithCachedRoutesin my test case - I have a test where I check various permissions, the routes in my web.php are flagged, depending on the feature so I need to make sure the test is refreshed as older cached routes don't have the permissions I'm checking.I'd like the ability to do the below in my test - without the need for a new test case etc:
I've adjusted both properties to allow for null to keep them inline. There could probably be further adjustments to allow for methods to do this like
withoutCachedRoutesfor better dx, but for now I just want to do it myself.Dont think it's a breaking change, but open to feedback - cheers 👍🏻