-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[12.x] PHP 8.5 Compatibility #57835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.x] PHP 8.5 Compatibility #57835
Conversation
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
|
would it make more sense to use something like |
|
@browner12 The constant is temporarily used until symfony/polyfill#549 gets merged. We hope it will be available before PHP 8.5.0 stable release is available but we need to prepare all our 1st party packages right now. |
|
yah, I wasn't suggesting not checking the version. I was just suggesting to stay consistent with other version checking in the FW and switch: PHP_VERSION_ID >= 80500;to version_compare(phpversion(), '8.5.0', '>=');if you don't expect this code to stay in long, I guess I'm indifferent, but if it'll be in there a bit would be nice to stay consistent. |
Uh oh!
There was an error while loading. Please reload this page.