[12.x] RateLimiter remaining to 0 to prevent negative values. #57851
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
remaining()andretriesLeft()in theCacheLimiterwill never return negative values when the attempt counter exceeds the allowed attempts.When the rate limit counter exceeds the
maxAttemptsthe calculation$maxAttempts - $attemptscan be a negative number. The solution usesmax(0, $maxAttempts - $attempts)to clamp the result to 0.