Skip to content

[12.x] Incorrect result of MemoizedStore::many with numeric keys and empty prefix #57862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2025
+18 −6
Merged

[12.x] Incorrect result of MemoizedStore::many with numeric keys and empty prefix #57862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc19412
[12.x] MemoizedStoreTest with empty prefix
vadimonus Nov 22, 2025
9264a02
[12.x] MemoizedStore fix with empty prefix and numeric keys
vadimonus Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/Illuminate/Cache/MemoizedStore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,9 @@ public function many(array $keys)

if (count($missing) > 0) {
$retrieved = tap($this->repository->many($missing), function ($values) {
$this->cache = [
...$this->cache,
...collect($values)->mapWithKeys(fn ($value, $key) => [
$this->prefix($key) => $value,
]),
];
foreach ($values as $key => $value) {
$this->cache[$this->prefix($key)] = $value;
}
});
}

Expand Down
15 changes: 15 additions & 0 deletions tests/Integration/Cache/MemoizedStoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,21 @@ public function test_it_uses_correct_keys_for_getMultiple()
$this->assertSame($cacheValue, $memoValue);
}

public function test_it_uses_correct_keys_for_getMultiple_with_empty_prefix()
{
Cache::setPrefix(null);

$data = [
'1' => 'one',
0 => 'zero',
];
Cache::putMany($data);

$this->assertSame($data, Cache::memo()->many(array_keys($data)));
// ensure correct on the second memoized retrieval
$this->assertSame($data, Cache::memo()->many(array_keys($data)));
}

public function test_null_values_are_memoized_when_retrieving_multiple_values()
{
$live = Cache::getMultiple(['name.0', 'name.1']);
Expand Down
Loading