Skip to content

[13.x] Default PendingRequest@pool() to use 2 for concurrency #57972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 6 commits into from
Nov 29, 2025
Merged

[13.x] Default PendingRequest@pool() to use 2 for concurrency #57972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cee90ff
remove footgun
cosmastech Nov 29, 2025
603c808
allow passing callable
cosmastech Nov 29, 2025
c5e072f
Update PendingRequest.php
cosmastech Nov 29, 2025
336337f
explicitly run the pool in series
cosmastech Nov 29, 2025
3fe93b9
match behavior
cosmastech Nov 29, 2025
bdaf4e0
Update PendingRequest.php
taylorotwell Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Http/Client/PendingRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ public function delete(string $url, $data = [])
* @param int|null $concurrency
* @return array<array-key, \Illuminate\Http\Client\Response|\Illuminate\Http\Client\ConnectionException|\Illuminate\Http\Client\RequestException>
*/
public function pool(callable $callback, ?int $concurrency = null)
public function pool(callable $callback, ?int $concurrency = 0)
{
$results = [];

Expand Down
8 changes: 4 additions & 4 deletions tests/Http/HttpClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3527,14 +3527,14 @@ public function testItCanEnforceFakingInThePool()
$this->assertSame(200, $responses[0]->status());
$this->assertSame(200, $responses[1]->status());

$this->expectException(StrayRequestException::class);
$this->expectExceptionMessage('Attempted request to [https://laravel.com] without a matching fake.');

$this->factory->pool(function (Pool $pool) {
[$exception] = $this->factory->pool(function (Pool $pool) {
return [
$pool->get('https://laravel.com'),
];
});

$this->assertInstanceOf(StrayRequestException::class, $exception);
$this->assertEquals('Attempted request to [https://laravel.com] without a matching fake.', $exception->getMessage());
Comment on lines +3530 to +3537
Copy link
Contributor Author

@cosmastech cosmastech Nov 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified this test to match how we are testing other pooled exceptions in this file. The exception was being thrown because the pool was running in series rather than actually as a pool. This behavior better lines up with how it should be used (in my opinion).

}

public function testPreventingStrayRequests()
Expand Down
Loading