[4.2] Fixed Carbon InvalidArgumentException When Using toArray or toJson On Unset Timestamps

[anyday]

An unset Timestamp in database would sometimes cause Carbon to fail:
InvalidArgumentException in Carbon.php line 385: Unexpected data found.

Proposed changes fix issue.

[lagbox]

interesting

[anyday]

Just to be clear, the issue crops up when a Timestamp field in the database has it's default value of 0000-00-00 00:00:00. (due to an insert such as DB::raw() )

[GrahamCampbell]

Could you add a test please.

[anyday]

Added a test.

[GrahamCampbell]

Please remove all trailing whitespace.

[anyday]

Fixed.

[GrahamCampbell]

1) DatabaseEloquentModelTest::testToArrayIncludesNulledMysqlTimestamps
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'0000-00-00 00:00:00'
+'-0001-11-30 00:00:00'

[GrahamCampbell]

This test is still failing.

[anyday]

A bit perplexed, because the change I made to the original code wouldn't set it negative -- so I imagine my test will fail without my change to the core code as well.

I'll need to figure out why that's happening.

I'm fairly new to Laravel so not sure exactly where to look.

[anyday]

That negative you're getting is what I get with the old code.

I did have an error in the test because of copy /paste syndrome, but that has been corrected.

[anyday]

The test is failing because it isn't testing my changes made in
src/Illuminate/Database/Eloquent/Model.php

[GrahamCampbell]

Please rebase, and squash, if the tests are still failing, then it's 100% caused by your changes.

[taylorotwell]

I don't really agree with this change. If it's a date give it a valid date. I don't think it should just be missing from the resulting array.