[4.2] Fixed port separator in DSN when using dblib with PDO in sql server connector #6642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could you add a test for this? |
Contributor
Author
|
@GrahamCampbell or @taylorotwell I updated the existing test which covers both the |
GrahamCampbell
changed the title
taylorotwell
added a commit
that referenced
this pull request
Dec 15, 2014
[4.2] Fixed port separator in DSN when using dblib with PDO in sql server connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing with Laravel and SQL server the past few days.
Without this I get a
PDOExceptionwithSQLSTATE[HY000] Unknown host machine name (severity 2)on my Mac connecting to SQL server.I believe it's because dblib is Unix it is expecting a Unix style port separator
:and thesqlsrvoption is expecting,as it is the Windows style. Thesqlsrvoption works fine when I'm on Windows running Laravel.Propel ORM has some dblib DSN examples that match too:
http://propelorm.org/Propel/cookbook/using-mssql-server.html#pdodblib