[5.0] Fix Eloquent integration tests #7096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
That's not what those tags mean. "database" means the pull is related in some way to the database component. And the "bug" means this pull request is fixing something. The "low priority" means the bug doesn't affect many people - in this case, nobody because it's a typo in the tests. |
JosephSilber
force-pushed
the
correct-method
branch
from
0a5b76a to
68486e0
Compare
JosephSilber
force-pushed
the
correct-method
branch
from
68486e0 to
421228d
Compare
JosephSilber
changed the title
taylorotwell
added a commit
that referenced
this pull request
Jan 23, 2015
[5.0] Fix Eloquent integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems these tests never ran, because it was missing the
Testsuffix.I now changed that and fixed it up.