Skip to content

Conversation

@brunogaspar
Copy link
Member

Added a config_path(:path) helper function, which i believe to make sense, it stays consistent with the app_path(:path) and base_path(:path) methods and will also help a bit when writing the Service Providers for the new publisher command.

Will you consider a database_path(:path) as well? I find both helper functions to be useful when writing the Service Providers as config and migrations are the most common things on packages, language files is another thing, but, i rarely see them.

Added a `config_path(:path)` helper function, which i believe to make sense, it stays consistent with the `app_path(:path)` and `base_path(:path)` methods and will also help a bit when writing the Service Providers for the new publisher command.

> Will you consider a `database_path(:path)` as well? I find both helper functions to be useful when writing the Service Providers as config and migrations are the most common things on packages, language files is another thing, but, i rarely see them.
@crynobone
Copy link
Member

Not sure how useful config_path() as $path is not going to be used (as of current Laravel 5) with the way Illuminate\Config\Repository works right now.

@GrahamCampbell
Copy link
Collaborator

Yeh, @crynobone is correct.

@brunogaspar
Copy link
Member Author

I found it useful when using the new package publish feature/command.

@GrahamCampbell
Copy link
Collaborator

The decision is ultimately up to Taylor. I'll leave this for him to review.

@GrahamCampbell GrahamCampbell changed the title [L5] Added a config_path() helper function [5.0] Added a config_path() helper function Jan 25, 2015
taylorotwell added a commit that referenced this pull request Jan 26, 2015
[5.0] Added a config_path() helper function
@taylorotwell taylorotwell merged commit 63c0fed into laravel:master Jan 26, 2015
@taylorotwell
Copy link
Member

Will add since it is somewhat useful for config publishing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants