[5.0] Dispatch commands through a pipeline #7189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending commands through a pipeline will allow for easier decoration of the command bus. Additional dispatchers can be used as pipes and can independently handle resolving handlers and firing handle method.
src/Illuminate/Bus/Dispatcher.php
Outdated
Collaborator
There was a problem hiding this comment.
Don't allow this. Always require the injected object.
Contributor
Author
There was a problem hiding this comment.
thanks @GrahamCampbell -- I will make all the necessary changes. I was just really putting this out there as a feeler to see if this would be something other users might be interested in.
Contributor
Author
|
@GrahamCampbell thanks, made recommended changes |
src/Illuminate/Bus/Dispatcher.php
Outdated
Collaborator
There was a problem hiding this comment.
null isn't correct
Contributor
Author
|
more updates, per @GrahamCampbell |
Contributor
|
👍 I love it! |
Collaborator
|
Please squash to one commit. |
GrahamCampbell
changed the title
Member
|
Did this a little differently. ^ In BusServiceProvider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending commands through a pipeline will allow for easier decoration of the command bus. Additional dispatchers can be used as pipes and can independently handle resolving handlers and firing handle method.