Add sub-directories to config keys #7363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory. Also mergeConfigFrom will check if a directory is given as $path and merge all files properly.
composer.json
Outdated
Contributor
There was a problem hiding this comment.
If you want this PR to have even the slightest chance of surviving, you should remove this.
Author
There was a problem hiding this comment.
I have no idea how that ends up here, been messing with satis and composer etc. Was not intended to end up here.
Author
There was a problem hiding this comment.
O so it keeps adding new commits to an already made pull request, didn't expect that. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously config files placed inside a sub directory of config were keyed only by the file name. So config/subdir/file.php is accessible trough Config::get('file.')). With these edits it puts the sub directory in the key making it easier to group lots of config files and avoid overwriting config files with the same name. So config/subdir/file.php is accessible trough Config::get('subdir/file.')).