[5.1] Fix domain wildcard group in routes and url generation

[mackiecarr]

Allow the UrlGenerator route(...) function to get its parameters from the current request as suggested in issue #7366. With this you can either explicitly set the parameters or get them from the request.

Example:

Route::group(
    [
        'domain' => '{subdomain}.domain.com',
    ],
    function ($router) {
        Route::get(
            '/',
            [
                'uses' => function ($subdomain) use ($router) {
                    $route = $router->getCurrentRoute();
                    $action = $route->getAction();
                    $action['domain'] = $subdomain . '.domain.com';
                    $route->setAction($action);

                    return route('subhome');
                },
                'as' => 'subhome'
            ]
        );
    }
);

You can use route('subhome') with no other options and have it generate a correct URL.

Just a suggestion :)

[GrahamCampbell]

No need for the else block. Do this:

if (count($parameters) > 1) {
    return $this->toRoute($route, $parameters, $absolute);
}

return $this->toRoute($route, $route->bind($this->getRequest())->parameters(), $absolute);

[mackiecarr]

Made those changes, thanks!

[GrahamCampbell]

One too many tabs.

[GrahamCampbell]

Also, you need the new lines as I put them. Don't remove them.

[GrahamCampbell]

Better to replace this whole thing with this code:

    public function route($name, $parameters = array(), $absolute = true)
    {
        if (is_null($route = $this->routes->getByName($name)))
        {
            throw new InvalidArgumentException("Route [{$name}] not defined.");
        }

        if (count($parameters) > 0) {
            return $this->toRoute($route, $parameters, $absolute);
        }

        return $this->toRoute($route, $route->bind($this->getRequest())->parameters(), $absolute);
    }

[taylorotwell]

Still don't really like this.